text emitter: use singular form when there was only 1 unmatched diagnostic#343
text emitter: use singular form when there was only 1 unmatched diagnostic#343oli-obk merged 1 commit intooli-obk:mainfrom
Conversation
|
hmm I'll have to try the test suite locally, but are you sure it hangs and doesn't just take forever (it rebuilds a lot of things on the first run) |
|
Thanks for starting CI:)
I mean my laptop is admittedly quite slow, but AFAICT it isn't the rebuilding part that fails, just the integration test in particular: |
|
Oh, it did move after a while! The thing is that it completely maxed out all the CPUs, which is why I assumed that it got into an infinite loop somewhere EDIT: Okay, yeah, the following runs are much smoother |
|
Yea it rebuilds the crate for each of those tests |
fe024ef to
50a8838
Compare
|
I also got a bunch of seemingly unrelated changes when running EDIT: oh no, apparently some unrelated changes did end up sneaking into |
|
Maybe I need to do a version bump again of the rust version we use, let's see what CI says |
|
That does sound right -- many of the changes seem to come from improved rustc diagnostics EDIT: Ahh, right! That's because I have Cargo installed as a free-standing program (so not from rustup), which is why |
50a8838 to
f2fd3a3
Compare
|
Great! Thanks for the fix |
|
Sorry, I'd realized that my test case doesn't actually test what it was supposed to test -- I wanted to make it emit |
|
Hmm I saw the test changes for 1 unmatched diagnostic and forgot to check that there's still a case for 2+ |
|
|
||
| error: actual output differed from expected | ||
| Execute `DO NOT BLESS. These are meant to fail` to update `tests/actual_tests/bad_pattern_multiple.stderr` to the actual output | ||
| --- tests/actual_tests/bad_pattern_multiple.stderr |
There was a problem hiding this comment.
Could also bless the output so we only see the missing annotation error
| error: there was 1 unmatched diagnostic | ||
| --> tests/actual_tests/bad_pattern_multiple.rs:4:9 | ||
| | | ||
| 4 | add("42", 3); |
There was a problem hiding this comment.
Maybe there need to be multiple per line for there to be just one diagnostic informing us about multiple cases
There was a problem hiding this comment.
Tho I think it maybe best if we had one big diagnostic for all unmatched diagnostics,
TODO (check if already done)